apache / apache/beam

Combine semantics for empty bundle for min, max is wrong

Open
#18,509 0 comments 0 reactions 0 assignees View on GitHub
bug go P3
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
2d 5h
Merged PRs (30d)
204

Description

The combine semantics for Min for empty bundles is to emit MAX_INT, if using global windows. Our implementation currently deviates from java, because we use binary combiners (and thus emit the default element for the type (0).

Ditto for the other binary combiners in stats.

Imported from Jira [BEAM-3296](https://issues.apache.org/jira/browse/BEAM-3296). Original Jira may contain additional context.
Reported by: herohde.

Contributor guide

Open the contributing guide

Research direction

Start by locating the stats binary combiners and inspect how empty bundles are handled for Min, Max, and the other combiners. Compare their identities with the Java semantics described in the issue, then add or update tests showing the expected empty-bundle results for each affected combiner.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
data-engineering
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.