Replace the magic number 42 in PAssert.
Open
improvement
P3
tests
- Dominant language
- Java
- Stars
- 8.7k
- Forks
- 4.7k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 205
Description
PAssert used integer 42 as the global key. It causes some confusion when debugging ValidatesRunner tests.
final int combinedKey = 42;
https://github.com/apache/beam/find/master#L935
Imported from Jira [BEAM-1854](https://issues.apache.org/jira/browse/BEAM-1854). Original Jira may contain additional context.
Reported by: peihe0@gmail.com.
Contributor guide
Research direction
Start at the PAssert implementation near the linked line and inspect how the final int combinedKey = 42 value is used in ValidatesRunner tests. Determine an appropriate replacement for the global key, update the affected code, and verify the relevant PAssert or ValidatesRunner tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100