apache / apache/beam

Assert over metrics sent to Graphite

Open
#18,208 0 comments 0 reactions 0 assignees View on GitHub
improvement P3 runners spark
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

It would be great if we could have a way to assert over metrics sent by the `GraphiteSink` to an actual Graphite server.

At the moment we have similar tests for the `InMemoryMetrics` sink, which give a good level of confidence (that's why I've set this to Minor), but we might be able to stretch things even further by capturing metrics sent by the graphite reporter in the `GraphiteSink` using an in memory implementation of a simple Graphite server.

This could also be useful for other Beam components once they start reporting to Graphite.

Imported from Jira [BEAM-1215](https://issues.apache.org/jira/browse/BEAM-1215). Original Jira may contain additional context.
Reported by: staslev.

Contributor guide

Open the contributing guide

Research direction

Start by locating GraphiteSink and the existing InMemoryMetrics tests. Then trace how GraphiteSink sends metrics and identify the test entry points for an in-memory Graphite server. Done means tests can capture and assert the metrics sent by GraphiteSink, with coverage comparable to the existing InMemoryMetrics tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
observability, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.