apache / apache/beam

io/google-cloud-platform should not depend on runners/dataflow for testing

Open
#18,207 0 comments 0 reactions 0 assignees View on GitHub
core java P3 task
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

dataflow-runner needs to depends on io/google-cloud-platform to specialize configurations.

Currently, it is done by putting GcsUtil in the sdk.util.
https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java#L189

It is no longer possible after FileSystem refactoring, given GcsFileSystem and its configuration will be in io/google-cloud-platform.

Imported from Jira [BEAM-1352](https://issues.apache.org/jira/browse/BEAM-1352). Original Jira may contain additional context.
Reported by: peihe0@gmail.com.

Contributor guide

Open the contributing guide

Research direction

Start with runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java, especially the GcsUtil use near line 189, and review the FileSystem refactoring that moves GcsFileSystem and its configuration into io/google-cloud-platform. Determine how testing can avoid a dataflow-runner dependency on io/google-cloud-platform; done means the dependency is removed while the affected tests and configurations still work.

Written by the indexing model from the issue text.

Assessment

Tech stack
google-cloud, java
Domain
build-system
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.