apache / apache/beam

DataflowRunner support for Class-Path jars

Open
#18,148 0 comments 0 reactions 0 assignees View on GitHub
dataflow new feature P3 runners
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

See https://github.com/GoogleCloudPlatform/DataflowJavaSDK/issues/538

The code that infers `--filesToStage` from the classpath does not seem to support a classpath jar. which uses a `Class-Path` manifest to indicate which other jars are needed at runtime. This is apparently a standard, approved way to pass the classpath.

We need to add this support to `DataflowRunner#detectClasspathResourcesToStage`, but correctly representing the user's classpath continues to be challenging.

(As `FlinkRunner` has copied this code, we should probably either pull the common utility somewhere public or update the FlinkRunner too?)

Imported from Jira [BEAM-1325](https://issues.apache.org/jira/browse/BEAM-1325). Original Jira may contain additional context.
Reported by: dhalperi.

Contributor guide

Open the contributing guide

Research direction

Start with DataflowRunner#detectClasspathResourcesToStage and review the referenced BEAM-1325 context. Trace how a classpath jar's Class-Path manifest is handled, then compare the copied logic in FlinkRunner. Done means the required jars are correctly represented and staged, with the FlinkRunner/common-utility impact resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
cloud, distributed-systems
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.