apache / apache/beam

Inline AfterDelayFromFirstElementStateMachine to AfterProcessingTimeStateMachine and simplify

Open
#18,117 0 comments 0 reactions 0 assignees View on GitHub
core improvement P3 runners
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
1d 20h
Merged PRs (30d)
196

Description

Currently, the runners/core-java implementation of processing time and synchronized processing time triggers share code that is actually unused and unsupported for synchronized processing time. It clarified things to just separate them in the SDK; we should do the same for the execution in runner/core-java.

Imported from Jira [BEAM-1486](https://issues.apache.org/jira/browse/BEAM-1486). Original Jira may contain additional context.
Reported by: kenn.

Contributor guide

Open the contributing guide

Research direction

Start in runners/core-java and locate AfterDelayFromFirstElementStateMachine and AfterProcessingTimeStateMachine. Read how processing-time and synchronized-processing-time triggers share their execution code, then separate the unsupported synchronized-processing-time path and inline the former state machine as described. Done means the runner no longer retains unused shared code and the two execution paths remain distinct.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
distributed-systems
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.