apache / apache/beam

Validation needs to exist that ValidatesRunner tests execute

Open
#18,062 0 comments 0 reactions 0 assignees View on GitHub
core dataflow direct flink gearpump improvement java P3 runners spark
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
2d 2h
Merged PRs (30d)
205

Description

We lack the validation that tests that were supposed to execute actually executed part of pre/post commit.

This is worrisome in an automated test environment since its difficult to know if all the tests that were supposed to run did run.

Repro steps:
checkout apache/master @ b8e6eea691b48e14c4e2c3e84609d750769e09ee
mvn clean integration-test -T 1C -pl runners/direct-java -am

Note that the SplittableParDoTest part of beam-runners-core-java doesn't execute.

Imported from Jira [BEAM-760](https://issues.apache.org/jira/browse/BEAM-760). Original Jira may contain additional context.
Reported by: lcwik.

Contributor guide

Open the contributing guide

Research direction

Start by running `mvn clean integration-test -T 1C -pl runners/direct-java -am` at commit b8e6eea691b48e14c4e2c3e84609d750769e09ee and inspect why SplittableParDoTest in beam-runners-core-java does not execute. Trace the pre/post-commit test validation path. Done means the validation detects when a test expected to run was skipped.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.