apache / apache/beam

Print Properties on validation failures in PipelineOptionsValidator

Open
#18,016 0 comments 0 reactions 0 assignees View on GitHub
core improvement java P3
Dominant language
Java
Stars
8.7k
Forks
4.7k
Avg merge
2d 5h
Merged PRs (30d)
204

Description

If Pipeline Validation fails in the pipeline options Validator, the methods that failed validation are printed. Instead, the property names (passed on the command line) should be printed for consistency with the PipelineOptionsFactory.

Currently methods are printed at https://github.com/apache/incubator-beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsValidator.java#L72

PipelineOptionsReflector currently extracts the property -\> method mapping
https://github.com/apache/incubator-beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsReflector.java#L95

Imported from Jira [BEAM-448](https://issues.apache.org/jira/browse/BEAM-448). Original Jira may contain additional context.
Reported by: tgroh.

Contributor guide

Open the contributing guide

Research direction

Start by reading PipelineOptionsValidator.java at the reported validation-failure code and PipelineOptionsReflector.java at the property-to-method mapping. Verify the existing Java core options tests or test coverage for validation failures, then confirm that failures report command-line property names rather than validator method names.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
developer-experience
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.