apache / apache/auron

Rename SemiJoin's JoinerParams.probe_is_join_side to is_probe_on_outer_side

Open
#1,809 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
1.8k
Forks
241
Avg merge
2d 12h
Merged PRs (30d)
21

Description

I was reading the semi join implementation and find that the field name: `JoinerParams.probe_is_join_side` is hard to understand its meaning:

https://github.com/apache/auron/blob/d357cbc100f01374059c4deaa6856af763164e4c/native-engine/datafusion-ext-plans/src/joins/bhj/semi_join.rs#L60-L64

`join_side` is NOT an adjective, it is a noun, which can be LEFT or RIGHT

https://github.com/apache/auron/blob/d357cbc100f01374059c4deaa6856af763164e4c/native-engine/auron-serde/proto/auron.proto#L678-L681

After some digging I think what `probe_is_join_side` want to say is: whether the probe side is the same as the outer side of the join. e.g. For a left join, if the probe side is on the left, then probe_is_join_side is true, otherwise false. BTW: For a left join, left side is the outer side, right side is the inner side.

So I suggest to rename `probe_is_join_side` to `is_probe_on_outer_side` and add some comments to make it more easier to understand.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.