apache / apache/arrow

[Dev] Fix SC2035 shellcheck errors in the cpp/src/arrow/vendored directory.

Open
#51,297 0 comments 0 reactions 1 assignee Claimed by @hiroyuki-sato View on GitHub
Component: Developer Tools Type: enhancement
Dominant language
C++
Stars
17.1k
Forks
4.3k
Avg merge
3d 13h
Merged PRs (30d)
88

Description

### Describe the enhancement requested

This is the sub issue #44748.

* Use `./*glob*` or `-- *glob*` so names with dashes won't become options.

```
In cpp/src/arrow/vendored/fast_float/update.sh line 40:
sed -i.bak -E -e "s/v[0-9.]+/v${version}/g" *.h
^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.

In cpp/src/arrow/vendored/fast_float/update.sh line 44:
*.h
^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.

In cpp/src/arrow/vendored/fast_float/update.sh line 45:
rm *.bak
^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.

In cpp/src/arrow/vendored/datetime/update.sh line 48:
*.{cpp,h,mm}
^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.

In cpp/src/arrow/vendored/datetime/update.sh line 51:
*.h
^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.

In cpp/src/arrow/vendored/datetime/update.sh line 55:
rm *.bak
^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.

In cpp/src/arrow/vendored/double-conversion/update.sh line 38:
rm *.cc *.h
^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.
^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.

In cpp/src/arrow/vendored/double-conversion/update.sh line 43:
sed -i.bak -E -e "s/v[0-9.]+/v${version}/g" *.md
^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.

In cpp/src/arrow/vendored/double-conversion/update.sh line 49:
*.{h,cc}
^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.

In cpp/src/arrow/vendored/double-conversion/update.sh line 50:
rm *.bak
^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.

For more information:
https://www.shellcheck.net/wiki/SC2035 -- Use ./*glob* or -- *glob* so name...
```

### Component(s)

Developer Tools

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.