apache / apache/arrow

[C++][Arrow Flight SQL ODBC] Fix value for `lpstrFilter`

Open
#47,851 0 comments 0 reactions 0 assignees View on GitHub
Component: C++ Component: FlightRPC Type: enhancement
Dominant language
C++
Stars
17.1k
Forks
4.3k
Avg merge
3d 13h
Merged PRs (30d)
88

Description

### Describe the enhancement requested

From https://learn.microsoft.com/en-us/windows/win32/api/commdlg/ns-commdlg-openfilenamea:
> To retrieve a shortcut's target without filtering, use the string "All Files\0*.*\0\0".

AC:

https://github.com/apache/arrow/blob/bab558061696ddc1841148d6210424b12923d48e/cpp/src/arrow/flight/sql/odbc/odbc_impl/ui/dsn_configuration_window.cc#L569-L570
In above code, replace `All\0*.*` with `"All Files\0*.*\0\0"`. Since ODBC is using unicode, using the wide character string is the correct choice here. \

Parent issue: https://github.com/apache/arrow/issues/30622

### Component(s)

C++, FlightRPC

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.