apache / apache/arrow

[C++] Issue with define ARROW_CXX_COMPILER_FLAGS

Open
#40,762 0 comments 0 reactions 1 assignee Claimed by @helly25 View on GitHub
Component: C++ Type: bug
Dominant language
C++
Stars
17.1k
Forks
4.3k
Avg merge
3d 13h
Merged PRs (30d)
88

Description

### Describe the bug, including details regarding any error messages, version, and platform.

The define `ARROW_CXX_COMPILER_FLAGS` has issues with some forms of flags. For instance our build system automatically generates suppressions like `-D__DATE__=\"redacted\"`. The result is a compiler error in `cpp/src/arrow/util/config.h.cmake`.

While cmake could provide correctly escaped flag strings, it is much easier to use raw strings to solve the issue, e.g.:

```
#define ARROW_CXX_COMPILER_FLAGS R"(@CMAKE_CXX_FLAGS@)"
```

### Component(s)

C++

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.