apache / apache/arrow

[C++][Acero] acero DeclarationToRecordBatchGenerator ignores sequece_output parameter

Open
#36,881 0 comments 0 reactions 0 assignees View on GitHub
Component: C++ Type: bug
Dominant language
C++
Stars
17.1k
Forks
4.3k
Avg merge
3d 13h
Merged PRs (30d)
88

Description

### Describe the bug, including details regarding any error messages, version, and platform.

when called `DeclarationToReader`, it calls `DeclarationToRecordBatchGenerator`, but when setting `SinkNodeOptions`, `sequence_output` parameter is ignored.
It should fail when the plan is validated.

https://github.com/apache/arrow/blob/5a9240fd28e1d7261a10a4816301d22995cfb8e0/cpp/src/arrow/acero/exec_plan.cc#L1019-L1021

It should be easy to fix, but the downstream `DeclarationToReader` will not return the error state when it called to `DeclarationToRecrodBatchGenerator`.

https://github.com/apache/arrow/blob/5a9240fd28e1d7261a10a4816301d22995cfb8e0/cpp/src/arrow/acero/exec_plan.cc#L1039-L1048

### Component(s)

C++

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.