apache / apache/arrow

[C++] Problem when used from "qlora", huggingface. Does not clean up, and dumps core.

Open
#35,876 9 comments 3 reactions 0 assignees View on GitHub
Component: C Component: C++ Type: bug
Dominant language
C++
Stars
17.1k
Forks
4.3k
Avg merge
3d 18h
Merged PRs (30d)
91

Description

### Describe the bug, including details regarding any error messages, version, and platform.

/arrow/cpp/src/arrow/filesystem/s3fs.cc:2598: arrow::fs::FinalizeS3 was not called even though S3 was initialized. This could lead to a segmentation fault at exit
Segmentation fault (core dumped)

Ubuntu 20.04

arrow==1.2.3
pyarrow==12.0.0

### Component(s)

C, C++

Contributor guide

Open the contributing guide

Research direction

Start in cpp/src/arrow/filesystem/s3fs.cc around line 2598 and reproduce the reported exit-time warning and segmentation fault with Arrow 1.2.3 and pyarrow 12.0.0 on Ubuntu 20.04. Trace S3 initialization and finalization during the qlora use case; done means cleanup occurs without the warning or core dump.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, huggingface, python
Domain
cloud
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.