apache / apache/arrow

[R] Test quarter-year parser with trailing zeroes in the year when values are numeric

Open
#33,479 2 comments 0 reactions 0 assignees View on GitHub
Component: R Type: enhancement
Dominant language
C++
Stars
17.1k
Forks
4.3k
Avg merge
3d 13h
Merged PRs (30d)
88

Description

In ARROW-18285 we removed some tests that had trailing zeroes in numeric inputs (e.g., `1.2020`). This used to work in lubridate but support was removed (probably not on purpose; follow-up with lubridate is here: https://github.com/tidyverse/lubridate/issues/1091 ). The behaviour still works in arrow but because our test tests "roundtrip" behaviour it was causing a lot of CI to fail so that specific corner case was removed. When this is resolved in lubridate, we could consider re-adding those cases.

**Reporter**: [Dewey Dunnington](https://issues.apache.org/jira/browse/ARROW-18304) / @paleolimbot

**Note**: *This issue was originally created as [ARROW-18304](https://issues.apache.org/jira/browse/ARROW-18304). Please see the [migration documentation](https://github.com/apache/arrow/issues/14542) for further details.*

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the removed numeric-input cases from ARROW-18285 and the related lubridate issue 1091. Check whether lubridate has restored support for values such as `1.2020`; when it has, re-add the quarter-year roundtrip cases and confirm that CI no longer fails.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.