apache / apache/arrow

[C++] Acero should reject Substrait plans that require an implicit cast from decimal to float

Open
#33,381 0 comments 0 reactions 0 assignees View on GitHub
Component: C++ Type: bug
Dominant language
C++
Stars
17.1k
Forks
4.3k
Avg merge
3d 18h
Merged PRs (30d)
91

Description

There are a number of functions that Acero currently implements for decimal types by first casting to float implicitly. Substrait does not allow for this kind of implicit cast. If a plan does not have a decimal-native implementation of a function then it should reject the plan.

**Reporter**: [Weston Pace](https://issues.apache.org/jira/browse/ARROW-18193) / @westonpace

**Note**: *This issue was originally created as [ARROW-18193](https://issues.apache.org/jira/browse/ARROW-18193). Please see the [migration documentation](https://github.com/apache/arrow/issues/14542) for further details.*

Contributor guide

Open the contributing guide

Research direction

Start with Acero's Substrait plan handling and the decimal-related function implementations. Trace which functions currently rely on an implicit decimal-to-float cast, then verify that plans lacking a decimal-native implementation are rejected; the issue names no files or tests, so repository search is needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
data-engineering
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.