apache / apache/arrow

[C++] Temporal floor/ceil/round should have settable origin unit

Open
#31,896 0 comments 0 reactions 0 assignees View on GitHub
Component: C++ Type: bug
Dominant language
C++
Stars
17.1k
Forks
4.3k
Avg merge
3d 18h
Merged PRs (30d)
91

Description

Temporal rounding kernels (will) allow setting of rounding origin to a greater unit. This could be made more flexible by introducing a `greater_unit` parameter which would let user select the unit serving as origin. See [this discussion](https://github.com/apache/arrow/pull/12657#issuecomment-1119580484) for more context.

**Reporter**: [Rok Mihevc](https://issues.apache.org/jira/browse/ARROW-16535) / @rok
**Watchers**: [Rok Mihevc](https://issues.apache.org/jira/browse/ARROW-16535) / @rok

**Note**: *This issue was originally created as [ARROW-16535](https://issues.apache.org/jira/browse/ARROW-16535). Please see the [migration documentation](https://github.com/apache/arrow/issues/14542) for further details.*

Contributor guide

Open the contributing guide

Research direction

Start by locating the C++ temporal rounding kernels referenced in the issue and read the linked discussion for the intended origin-unit behavior. The change is complete when floor, ceil, and round accept a greater_unit parameter that selects the unit serving as the rounding origin.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
data
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.