apache / apache/arrow

[C++] Temporal floor/ceil/round kernels could be optimised with templating

Open
#31,229 3 comments 0 reactions 1 assignee Claimed by @rok View on GitHub
Component: C++ Type: enhancement
Dominant language
C++
Stars
17.1k
Forks
4.3k
Avg merge
3d 18h
Merged PRs (30d)
91

Description

[CeilTemporal, FloorTemporal, RoundTemporal](https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc#L728-L980) kernels could probably be templated in a clean way. They also execute a switch statement for every call instead of creating an operator at kernel call time and only running that.

**Reporter**: [Rok Mihevc](https://issues.apache.org/jira/browse/ARROW-15787) / @rok
**Assignee**: [Rok Mihevc](https://issues.apache.org/jira/browse/ARROW-15787) / @rok
**Watchers**: [Rok Mihevc](https://issues.apache.org/jira/browse/ARROW-15787) / @rok
#### PRs and other links:
- [GitHub Pull Request #13043](https://github.com/apache/arrow/pull/13043)

**Note**: *This issue was originally created as [ARROW-15787](https://issues.apache.org/jira/browse/ARROW-15787). Please see the [migration documentation](https://github.com/apache/arrow/issues/14542) for further details.*

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.