apache / apache/arrow

[C++] BinaryBuilder doesn't preserve passed in DataType

Open
#29,309 8 comments 0 reactions 1 assignee Claimed by @BITree2004 View on GitHub
Component: C++ good-first-issue Type: bug
Dominant language
C++
Stars
17.1k
Forks
4.3k
Avg merge
3d 13h
Merged PRs (30d)
88

Description

There is a [constructor](https://github.com/apache/arrow/blob/1430c93f68960e10a50d27f465eb174e76ac06b2/cpp/src/arrow/array/builder_binary.h#L56) that takes a datatype for binary builder but it is discarded.  When constructing an Array the type is always the value returned from type() [binary](https://github.com/apache/arrow/blob/1430c93f68960e10a50d27f465eb174e76ac06b2/cpp/src/arrow/array/builder_binary.h#L390)

If a consumer of the API wants to have an extension array this prevents them from passing the extension type though.

**Reporter**: [Micah Kornfield](https://issues.apache.org/jira/browse/ARROW-13672) / @emkornfield
#### Related issues:
- [[C++] BinaryBuilder doesn't preserve passed in DataType](https://github.com/apache/arrow/issues/29310) (is duplicated by)
#### PRs and other links:
- [GitHub Pull Request #11910](https://github.com/apache/arrow/pull/11910)

**Note**: *This issue was originally created as [ARROW-13672](https://issues.apache.org/jira/browse/ARROW-13672). Please see the [migration documentation](https://github.com/apache/arrow/issues/14542) for further details.*

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.