apache / apache/arrow-swift

[Swift] Loading unaligned flatbuffers objects

Open
#14 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
32
Forks
18
Avg merge
19h 14m
Merged PRs (30d)
2

Description

Hello,

I'm the maintainer of the flatbuffers swift port, and we have a couple of changes within the pipeline https://github.com/google/flatbuffers/pull/8484#issuecomment-2594701128 that might be important for arrow.

TLDR: We refactored the implementation of a bytebuffer to directly read from `[Data, UInt8, ContiguousBytes, pointers]` aka without copying the data from those objects into our own internal storage. And we want to know if this will break anything, and if we need to return the flag `allowReadingUnalignedObjects` since in theory the first 4 bytes of the and byte buffer should be a valid root for a Flatbuffer object even if unaligned. One way to say that this byte buffer has a valid flat buffer object is to use the verifier before reading any data

Wasn't sure where to tag this, so sorry in advance

### Component(s)

Swift

Contributor guide

Open the contributing guide

Research direction

Start with the Swift port's byte buffer implementation and the verifier, then review the linked FlatBuffers pipeline discussion. Determine whether direct reads from Data, UInt8, ContiguousBytes, and pointers affect unaligned FlatBuffer objects. Done means documenting the compatibility result and deciding whether allowReadingUnalignedObjects must be returned.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
data
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.