apache / apache/arrow-rs

[Variant] Consider consolidating struct builders between `variant_get` and `shred_variant`

Open
#9,633 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
3.6k
Forks
1.3k
Avg merge
2d 18h
Merged PRs (30d)
169

Description

It looks like this `shredded` param allows quite a bit of code reuse. Should we look at other shred-vs-get pairs to see if similar consolidation is possible? Struct, in particular, is likely to be complex?

_Originally posted by @scovich in https://github.com/apache/arrow-rs/pull/9631#discussion_r3015998805_

Contributor guide

Open the contributing guide

Research direction

Start by locating the implementations of `variant_get` and `shred_variant`, then compare how their struct builders use the `shredded` parameter. Review other shred-versus-get pairs for similar patterns; done means the consolidation scope is resolved and the relevant builders share an appropriate implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
data
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.