apache / apache/arrow-rs

Parquet bool column SortOrder being UNSIGNED?

Open
#6,544 7 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Rust
Stars
3.6k
Forks
1.3k
Avg merge
2d 18h
Merged PRs (30d)
169

Description

**Describe the bug**
Hi, please close if it's intended. It seems that SortOrder for bool is [UNSIGNED](https://github.com/jp0317/arrow-rs/blob/master/parquet/src/basic.rs#L625) in rust but [SIGNED](https://github.com/apache/arrow/blob/main/cpp/src/parquet/types.cc#L272-L277) in c++ implementation. Should the rust implementation also be SIGNED?

**To Reproduce**
n/a

**Expected behavior**
Consistency?

**Additional context**
n/a

Contributor guide

Open the contributing guide

Research direction

Start in parquet/src/basic.rs at the bool SortOrder definition, then compare it with the referenced C++ implementation in cpp/src/parquet/types.cc. Determine whether the Rust and C++ behaviors should agree, and consider the relevant Parquet semantics; the issue is done when the intended bool SortOrder is established and the Rust behavior is consistent with it.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.