apache / apache/arrow-rs

Some `unsafe` code in arrow is seemingly unsound or not very well documented.

Open
#6,020 2 comments 2 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
Rust
Stars
3.6k
Forks
1.3k
Avg merge
2d 18h
Merged PRs (30d)
169

Description

Hi all,
while going through the code in `arrow`, I spotted a few places in which the usage of unsafe code is unsound, and a few in which I could not determine whether it was or not.

I do not believe that the issues I found could cause problems *today*, but I prepared a PR nonetheless that fixes the unsound cases I could find, improves documentation in the cases in which I could figure out why the code is indeed sound, and leaves a FIXME comment for the remaining cases that were beyond my ability to figure out :-)

I hope this helps!

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the unsafe code in arrow and the cases described in the issue. Determine which uses are unsound, document why the cases that are sound are safe, and leave FIXME comments for cases that cannot be established; done means these findings are addressed or explicitly recorded.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
data
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.