apache / apache/arrow-java

[Java] ORC JNI bridge should use the C data interface

Open
#350 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
94
Forks
152
Avg merge
3d 16h
Merged PRs (30d)
11

Description

Right now the ORC JNI bridge uses some custom buffer passing which only seems to handle primitive arrays correctly (child array buffers and dictionaries are not considered):
https://github.com/apache/arrow/blob/master/cpp/src/jni/orc/jni_wrapper.cpp#L263-L265

Instead, it should use the C data interface, which is now implemented in Java.

**Reporter**: [Antoine Pitrou](https://issues.apache.org/jira/browse/ARROW-15754) / @pitrou

**Note**: *This issue was originally created as [ARROW-15754](https://issues.apache.org/jira/browse/ARROW-15754). Please see the [migration documentation](https://github.com/apache/arrow/issues/14542) for further details.*

Contributor guide

Open the contributing guide

Research direction

Start with cpp/src/jni/orc/jni_wrapper.cpp around lines 263-265 and review the Java C data interface implementation. Trace how the ORC JNI bridge currently passes buffers, then verify that the interface covers child array buffers and dictionaries. Done means the bridge uses the C data interface for those cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, cpp, java
Domain
data-engineering
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.