apache / apache/arrow-go

[IPC/Go] Flatbuffers package declared as internal - Useful with custom MessageReaders

Open
#53 0 comments 0 reactions 0 assignees View on GitHub
Type: enhancement
Dominant language
Assembly
Stars
404
Forks
145
Avg merge
2d 4h
Merged PRs (30d)
87

Description

### Describe the enhancement requested

Hi,

While building a custom MessageReader I realized that the flatbuffers package in go is declared internal. Yet, this is of importance when reading the header metadata and to determine the size of the body when parsing IPC messages.
I would be curious if there is any reason why you declare that internal, and if not could that be changed?

As far as I got it from the docs, creating custom IPC MessageReaders is something you consider a valid use case:

https://pkg.go.dev/github.com/apache/arrow/go/arrow@v0.0.0-20211112161151-bc219186db40/ipc#NewReaderFromMessageReader
```
NewReaderFromMessageReader allows constructing a new reader object with the provided MessageReader allowing injection of reading messages other than by simple streaming bytes such as Arrow Flight which receives a protobuf message
```

### Component(s)

Go

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.