apache / apache/arrow-adbc

c/driver/postgresql: Implement COPY Writer support for time (ms, ns, s) types

Open
#3,841 0 comments 0 reactions 0 assignees View on GitHub
Type: enhancement
Dominant language
C#
Stars
627
Forks
217
Avg merge
17h
Merged PRs (30d)
57

Description

### What feature or improvement would you like to see?

```
FAILED tests/test_ingest.py::TestIngest::test_create[postgresql:15+:ingest/time_ms] - adbc_driver_manager.InternalError: INTERNAL: nanoarrow call failed: writer.InitFieldWriters(type_resolver, &na_error) = (22) Invalid argument. COPY Writer not implemented for type 20
FAILED tests/test_ingest.py::TestIngest::test_create[postgresql:15+:ingest/time_ns] - adbc_driver_manager.InternalError: INTERNAL: nanoarrow call failed: writer.InitFieldWriters(type_resolver, &na_error) = (2) No such file or directory.
FAILED tests/test_ingest.py::TestIngest::test_create[postgresql:15+:ingest/time_s] - adbc_driver_manager.InternalError: INTERNAL: nanoarrow call failed: writer.InitFieldWriters(type_resolver, &na_error) = (22) Invalid argument. COPY Writer not implemented for type 20
FAILED tests/test_query.py::TestQuery::test_query[postgresql:15+:type/bind/time_ms] - adbc_driver_manager.InternalError: INTERNAL: nanoarrow call failed: MakeCopyFieldWriter(bind_schema->children[i], array_view->children[i], type_resolver, &writer, &na_error) = (22) Invalid argument. COPY Writer not implemented for type 20
FAILED tests/test_query.py::TestQuery::test_query[postgresql:15+:type/bind/time_ns] - adbc_driver_manager.InternalError: INTERNAL: nanoarrow call failed: MakeCopyFieldWriter(bind_schema->children[i], array_view->children[i], type_resolver, &writer, &na_error) = (2) No such file or directory.
FAILED tests/test_query.py::TestQuery::test_query[postgresql:15+:type/bind/time_s] - adbc_driver_manager.InternalError: INTERNAL: nanoarrow call failed: MakeCopyFieldWriter(bind_schema->children[i], array_view->children[i], type_resolver, &writer, &na_error) = (22) Invalid argument. COPY Writer not implemented for type 20
```

These tests are being skipped right now because the PostgreSQL COPY Writer does not support these Arrow time types, throwing "COPY Writer not implemented for type 20" error.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.