apache / apache/arrow-adbc

dev/release: Omit APT/Yum repositories check on local in the RC verification script

Open
#2,770 4 comments 0 reactions 0 assignees View on GitHub
Type: enhancement
Dominant language
C#
Stars
627
Forks
217
Avg merge
17h
Merged PRs (30d)
57

Description

### What feature or improvement would you like to see?

`dev/release/verify-release-candidate.sh` verifies APT/Yum repositories by Docker. In general, verification by Docker always reports the same results. So we can omit them on local when we did it on CI.

Currently, we verify APT/Yum repositories by Docker on CI. For example, https://github.com/apache/arrow-adbc/actions/runs/14793223606 is the job for 18 RC 0.

It's triggered by "workflow run" manually: https://github.com/apache/arrow-adbc/blob/main/dev/release/06-binary-verify.sh

FYI: We implemented this in apache/arrow: https://github.com/apache/arrow/issues/45548

If we implement this for ADBC too, there is a problem. It seems that there is no easy way to find the verification job triggered by "workflow run"... We need to check `version` and `rc` inputs to detect the target job:

https://github.com/apache/arrow-adbc/blob/771b3c72af8a74f6fec76ef72d05f807d6062118/.github/workflows/verify.yml#L22-L32

But `gh run view` doesn't show inputs.

Can we use `push.tags` like apache/arrow too?
https://github.com/apache/arrow/blob/6006f1158e4bf044a98897b7b9cc732132d5579d/.github/workflows/verify_rc.yml#L21-L23

If we also use `push.tags` to trigger the job, we can find the target job by `branch=${TAG}` parameter:
https://github.com/apache/arrow/blob/6006f1158e4bf044a98897b7b9cc732132d5579d/dev/release/verify-release-candidate.sh#L186-L200

Contributor guide

Open the contributing guide

Research direction

Start with dev/release/verify-release-candidate.sh, dev/release/06-binary-verify.sh, and .github/workflows/verify.yml, then compare the corresponding Apache Arrow implementation. Check how version and RC inputs or push tags identify the CI verification job, including what gh run view exposes. Done means local verification omits APT/Yum Docker checks when the matching CI job has completed, while the RC workflow still verifies them.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, github-actions, shell
Domain
ci-cd, devops, release
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.