apache / apache/arrow-adbc

test(csharp/src/Drivers/Apache): extend double/float tests to include Min/Max

Open
#2,488 0 comments 0 reactions 0 assignees View on GitHub
Type: enhancement
Dominant language
C#
Stars
627
Forks
217
Avg merge
17h
Merged PRs (30d)
57

Description

### What feature or improvement would you like to see?

Add back tests for `MinValue` / `MaxValue` on Impala.

Are the deleted test values simply not supported in Impala? That wouldn't be surprising for NaN or the infinities, but is somewhat surprising for double.MinValue and double.MaxValue.

_Originally posted by @CurtHagenlocher in https://github.com/apache/arrow-adbc/pull/2365#pullrequestreview-2549791827_

Contributor guide

Open the contributing guide

Research direction

Start in csharp/src/Drivers/Apache and inspect the existing double/float tests, including the deleted values referenced in the issue. Determine whether Impala supports double.MinValue and double.MaxValue, then restore coverage for those values where supported and verify the relevant tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
databases, testing-qa
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.