r: setup-r-dependencies action is not running bootstrap.R before installing local packages
- Dominant language
- C#
- Stars
- 627
- Forks
- 217
- Avg merge
- 17h
- Merged PRs (30d)
- 57
Description
### What happened?
In https://github.com/apache/arrow-adbc/pull/1539, the R build failed because `driver_base.h` was not available. In debugging that, it turns out that configuration was *always* falling back on downloading files from `main` because `pkgbuild` or `pak` was running `bootstrap.R` *after* making a tarball of the `r/adbcdrivermanager` subdirectory. This defeats the whole purpose of `bootstrap.R` and probably needs to be fixed in the pkgbuild package.
This doesn't affect CRAN releases, which are built by `pkgbuild::build()` (which works great!).
### How can we reproduce the bug?
Remove the part of `r/adbcdrivermanager/configure` that `curl -L`s the files from main and run
```r
pak::local_install("r/adbcdrivermanager")
```
### Environment/Setup
pkgbuild 1.4.3, latest pak from CRAN.
Contributor guide
Research direction
Start with r/adbcdrivermanager/configure and the bootstrap.R flow described in the issue, then reproduce with pak::local_install("r/adbcdrivermanager") after removing the curl fallback. Trace how pkgbuild or pak creates the local package tarball and runs bootstrap.R; done means local installation makes driver_base.h available without downloading files from main.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, r
- Domain
- build-system, ci-cd
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100