apache / apache/arrow-adbc

go/adbc/driver/snowflake: GetObjects API doesn't return table constraints

Open
#1,319 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
627
Forks
217
Avg merge
17h
Merged PRs (30d)
57

Description

`GetObjects` API for snowflake go driver doesn't return table constraints: https://github.com/apache/arrow-adbc/blob/cac2d836c0371f86add8de0fe6f3d90293c808b0/go/adbc/driver/snowflake/connection.go#L177 as a part of `TABLE_SCHEMA`. Reference implementation can be found for the BigQuery driver: https://github.com/apache/arrow-adbc/blob/cc0c4e9c01b1feb7c175b22f7cc1b0d019751745/csharp/src/Drivers/BigQuery/BigQueryConnection.cs#L526

The goal would be:

- Add table constraints implementation for `GetObjects` within `getObjectsTables` method
- Add tests in https://github.com/ryan-syed/arrow-adbc/blob/main/csharp/test/Drivers/Snowflake/DriverTests.cs to check if the table constraints are returned
- Add parsing of table constraints in https://github.com/apache/arrow-adbc/blob/main/csharp/test/Apache.Arrow.Adbc.Tests/Metadata/GetObjectsParser.cs

Contributor guide

Open the contributing guide

Research direction

Start in go/adbc/driver/snowflake/connection.go at the getObjectsTables method and compare the BigQuery implementation linked in the issue. Review csharp/test/Drivers/Snowflake/DriverTests.cs and csharp/test/Apache.Arrow.Adbc.Tests/Metadata/GetObjectsParser.cs for the requested test and parsing coverage. Done means GetObjects returns table constraints and the tests verify them.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, go
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.