apache / apache/apisix-helm-chart
apisix-ingress-controller probe ports should come from .Values.config.probeAddr
- Dominant language
- Go Template
- Stars
- 289
- Forks
- 282
- Avg merge
- 15h 55m
- Merged PRs (30d)
- 3
Description
The port for the healthcheck probes can be configured with via .Values.config.probeAddr
It is used in [templates/configmap.yaml](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix-ingress-controller/templates/configmap.yaml):
```yaml
probe_addr: {{ .Values.config.probeAddr | default ":8081" }}
```
However in [templates/deployment.yaml](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix-ingress-controller/templates/deployment.yaml) this value is hardcoded:
```yaml
livenessProbe:
httpGet:
path: /healthz
port: 8081
initialDelaySeconds: 15
periodSeconds: 20
```
```yaml
readinessProbe:
httpGet:
path: /readyz
port: 8081
initialDelaySeconds: 5
periodSeconds: 10
```
They should use the same templating so the ports match and the probes can succeed.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with charts/apisix-ingress-controller/templates/configmap.yaml and templates/deployment.yaml, comparing how probeAddr is rendered and how the liveness and readiness probe ports are set. Render the chart with a custom .Values.config.probeAddr and verify both probes use the configured port while the default remains :8081.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- helm, kubernetes
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 85/100