apache / apache/apisix-helm-chart

Why are these values hardcoded Send_timeout, client_body_timeout in a template configmap?

Open Beginner friendly
#971 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go Template
Stars
289
Forks
282
Avg merge
15h 55m
Merged PRs (30d)
3

Description

Hello,

I’m trying to understand the configuration in `apisix/helm-charts/templates/configmap.yaml`.

I noticed this section:

```yaml
keepalive_timeout: {{ .Values.apisix.nginx.keepaliveTimeout | quote }}
client_header_timeout: 60s # timeout for reading client request header, then 408 (Request Time-out) error is returned to the client
client_body_timeout: 60s # timeout for reading client request body, then 408 (Request Time-out) error is returned to the client
send_timeout: 10s # timeout for transmitting a response to the client, then the connection is closed
```

Instead of using a more dynamic configuration like:

```yaml
client_header_timeout: {{ default "60s" .Values.apisix.nginx.clientHeaderTimeout }}
client_body_timeout: {{ default "60s" .Values.apisix.nginx.clientBodyTimeout }}
send_timeout: {{ default "10s" .Values.apisix.nginx.sendTimeout }}
```

Why are these values hardcoded instead of being configurable through `values.yaml`?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with apisix/helm-charts/templates/configmap.yaml and compare the existing keepaliveTimeout handling with values.yaml. Check how the proposed clientHeaderTimeout, clientBodyTimeout, and sendTimeout values would be represented and confirm that defaults preserve the current behavior while allowing overrides.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm, kubernetes
Domain
devops, infrastructure
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.