apache / apache/apisix-helm-chart

feat(apisix): Add namespace to manifest templates

Open
#949 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Go Template
Stars
289
Forks
282
Avg merge
15h 55m
Merged PRs (30d)
3

Description

## Context

Some manifest templates in the APISIX chart do not include `namespace: {{ .Release.Namespace }}`
in their metadata, for example:
- [templates/apisix-config-cm.yml](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/templates/apisix-config-cm.yml)
- [templates/ingress.yml](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/templates/ingress.yaml)

This is inconsistent with Helm best practices, where templates should respect
the namespace provided during installation via `--namespace` or `.Release.Namespace`.

## Expected behavior

All manifest templates should include:

metadata:
namespace: {{ .Release.Namespace }}

Is this an intentional design decision?

If not, would a PR adding `namespace: {{ .Release.Namespace }}` to the affected
templates be welcome?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with charts/apisix/templates/apisix-config-cm.yml and charts/apisix/templates/ingress.yaml, then inspect the other manifest templates for the same metadata pattern. Render the chart with a namespace value and verify that affected resources include that namespace without breaking the manifests; the issue's requested behavior defines done.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm, kubernetes
Domain
devops, infrastructure
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.