apache / apache/apisix-helm-chart
[ingress controller] maybe use "" namespace as serviceMonitor.namespace default
Open
Beginner friendly
enhancement
- Dominant language
- Go Template
- Stars
- 289
- Forks
- 282
- Avg merge
- 2d 19h
- Merged PRs (30d)
- 4
Description
[in here](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix-ingress-controller/values.yaml#L110) there is `monitoring` as default. That is inconsistent with [main apisix](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/values.yaml#L268).
Contributor guide
No contributing guide indexed for this repository
Research direction
Open charts/apisix-ingress-controller/values.yaml around line 110 and compare the serviceMonitor.namespace default with charts/apisix/values.yaml around line 268. Confirm the intended empty namespace default, update the ingress controller chart value, and verify the two defaults are consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- helm, kubernetes
- Domain
- infrastructure
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100