apache / apache/airflow

Rework `SUPERVISOR_COMMS.send_request` class/method to have `log` stored as a attribute

Open
#44,615 12 comments 0 reactions 0 assignees View on GitHub
area:task-execution-interface-aip72
Dominant language
Python
Stars
46.9k
Forks
17.8k
Avg merge
2d 10h
Merged PRs (30d)
483

Description

This reminds me: we should rework this class/method to have `log` stored as a attribute so we don't need to pass log in to this class.

(Future work; doing this will make it easier to use this from within XCom or Variable class.)

_Originally posted by @ashb in https://github.com/apache/airflow/pull/44590#discussion_r1867707822_

Contributor guide

Open the contributing guide

Research direction

Locate the SUPERVISOR_COMMS class and its send_request method, then inspect their callers and the linked discussion in pull request 44590. Determine how log is currently passed and what XCom or Variable usage requires; the work is done when log is stored on the class and callers no longer need to pass it.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.