apache / apache/airflow

Support for Flask-sesssion 0.6.0+

Open
#36,897 9 comments 4 reactions 0 assignees View on GitHub
kind:meta
Dominant language
Python
Stars
46.9k
Forks
17.9k
Avg merge
2d 7h
Merged PRs (30d)
484

Description

### Body

New version of [Flask-Session](https://pypi.org/project/Flask-Session/) breaks our [AirflowDatabaseSessionInterface](https://github.com/apache/airflow/blob/dae2d44695e0bf6eb87c184767cac26ebc5dadd8/airflow/www/session.py#L36) by add new arguments into the constructor sid_length, sequence, schema and bind_key and make all arguments are mandatory include previously optional use_signer and permanent

We limited flask-session to < 0.6.0 for now in https://github.com/apache/airflow/pull/36895 , but we need to update our code to fix it.

### Committer

- [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.

Contributor guide

Open the contributing guide

Research direction

Start by reading airflow/www/session.py at the AirflowDatabaseSessionInterface implementation and compare it with the Flask-Session 0.6.0+ constructor requirements. The change is complete when the interface supports Flask-Session 0.6.0+ and the temporary <0.6.0 constraint from PR #36895 can be removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
flask, python
Domain
backend, databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.