apache / apache/accumulo

schedule fate threads after fate construction

Open
#5,828 1 comment 0 reactions 1 assignee Claimed by @ArbaazKhan1 View on GitHub
enhancement
Dominant language
Java
Stars
1.2k
Forks
487
Avg merge
4d 5h
Merged PRs (30d)
13

Description

**Is your feature request related to a problem? Please describe.**
Would be safer to construct the Fate objects then call something like `fate.start()`. Right now, some of the fate threads will be started after a delay, but are scheduled in the constructor. Should be scheduled after construction to avoid any potential problems like leaking `this` before construction if the threads somehow run before construction completes.

**Describe the solution you'd like**
fate threads are scheduled in a new method like `start()` instead of in the constructor. Will need to change all uses of Fate to also call start.

**Additional context**
Fate constructor is currently leaking `this` with `startFateExecutors()`, but this is being removed in #5817.
This ticket should wait until that PR is merged.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.