apache / apache/accumulo

Property.isValidZooPropertyKey seems incorrect/outdated

Open
#5,695 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
1.2k
Forks
487
Avg merge
4d 5h
Merged PRs (30d)
13

Description

There are several prefixes not defined in `isValidZooPropertyKey`, which I'm not sure is by design. For example, should `isValidZooPropertyKey` include any of `RPC_PREFIX`, `INSTANCE_PREFIX`, `MONITOR_PREFIX`, `COMPACTOR_PREFIX`, etc? It seems like `FIXED_PROPERTIES` is meant to be a subset of those that are `isValidZooPropertyKey` (see descriptions for `isFixedZooPropertyKey` and `isValidZooPropertyKey`). However, there are several cases of a fixed property which would not be `isValidZooPropertyKey` (e.g., `COMPACTOR_PORTSEARCH` is in `FIXED_PROPERTIES` but would return false for `isValidZooPropertyKey`). Either
1) At least one description is incorrect and should be updated
2) `isValidZooPropertyKey` is missing some prefixes and should be updated

2 seems most likely

_Originally posted by @kevinrr888 in https://github.com/apache/accumulo/pull/5632#pullrequestreview-2917620497_

Contributor guide

Open the contributing guide

Research direction

Locate the definitions and descriptions of isValidZooPropertyKey, isFixedZooPropertyKey, FIXED_PROPERTIES, and the referenced prefixes. First compare the documented relationship with the current prefix lists and usages. Done means the descriptions and validation behavior agree for cases such as COMPACTOR_PORTSEARCH, with coverage for the resolved behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.