apache / apache/accumulo

2.1 still catching Error's

Open
#3,395 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
1.2k
Forks
487
Avg merge
4d 5h
Merged PRs (30d)
13

Description

`grep -R Error * | grep java | grep -i catch | grep -v AssertionError` on the source yields:

```
core/src/main/java/org/apache/accumulo/core/client/admin/NewTableConfiguration.java: } catch (LocalityGroupConfigurationError e) {
core/src/main/java/org/apache/accumulo/core/util/LocalityGroupUtil.java: } catch (LocalityGroupConfigurationError | RuntimeException e) {
core/src/main/java/org/apache/accumulo/core/clientImpl/NamespaceOperationsImpl.java: } catch (LocalityGroupConfigurationError | RuntimeException e) {
core/src/main/java/org/apache/accumulo/core/clientImpl/InstanceOperationsImpl.java: } catch (LocalityGroupConfigurationError | RuntimeException e) {
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java: } catch (LocalityGroupConfigurationError | RuntimeException e) {
core/src/test/java/org/apache/accumulo/core/util/LocalityGroupUtilTest.java: } catch (LocalityGroupConfigurationError err) {
server/base/src/main/java/org/apache/accumulo/server/rpc/TServerUtils.java: } catch (Error e) {
server/base/src/main/java/org/apache/accumulo/server/compaction/FileCompactor.java: } catch (LocalityGroupConfigurationError e) {
server/tserver/src/main/java/org/apache/accumulo/tserver/memory/NativeMapLoader.java: } catch (Exception | UnsatisfiedLinkError e) {
server/tserver/src/main/java/org/apache/accumulo/tserver/memory/NativeMapLoader.java: } catch (Exception | UnsatisfiedLinkError e) {
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java: } catch (Exception | Error e) {
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactor.java: } catch (IOException | UnsatisfiedLinkError e) {
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactor.java: } catch (RuntimeException | NoClassDefFoundError e) {
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletClientHandler.java: } catch (IOException | FSError ex) {
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletClientHandler.java: } catch (IOException | FSError ex) {
```

Need to evaluate these to see if we should fix these.

Contributor guide

Open the contributing guide

Research direction

Start with the grep results and inspect each listed catch in NewTableConfiguration.java, LocalityGroupUtil.java, the operations implementations, TServerUtils.java, FileCompactor.java, NativeMapLoader.java, Tablet.java, MinorCompactor.java, and TabletClientHandler.java. Determine which broad Error or related catches should change and document or implement the decisions consistently. Done means every reported catch has been evaluated and the necessary fixes are covered by the relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.