anvaka / anvaka/graph-drawing-libraries

Demo URLs are a bit broken

Open
#21 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
622
Forks
44
PR merge metrics
No merged PRs in 30d

Description

This is so nice, and so useful.

I had a bit of trouble navigating, though.

At https://anvaka.github.io/graph-drawing-libraries (which redirects to https://anvaka.github.io/graph-drawing-libraries/#!/all) all the "demo" links are slightly broken. They are like https://anvaka.github.io/graph-drawing-libraries/#/library/anvaka_VivaGraphJS but that renders as the same page as !/all. The experience is I click "demo" and nothing happens. If I manually change the URL to be like https://anvaka.github.io/graph-drawing-libraries/#!/library/anvaka_VivaGraphJS then they work.

Similar if I get through to the demo pages, like https://anvaka.github.io/graph-drawing-libraries/performance/?lib=anvaka_VivaGraphJS&graph=ladder&n=10 and then click on "render different graph", the URL is https://anvaka.github.io/graph-drawing-libraries/#/library/anvaka_VivaGraphJS when again it should have the ! to work.

Same behavior in Chromium Version 80.0.3987.149 (Official Build) snap (64-bit) and Firefox 74.0 (64-bit) for Ubuntu.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the demo links on the graph-drawing-libraries page and the "render different graph" navigation from the performance demo. Trace how those links construct the hash URL; done means both navigation paths include the ! form and open the selected library or graph instead of returning to the all page.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.