anvaka / anvaka/VivaGraphJS

API question concerning addLink

Open
#239 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3.9k
Forks
418
PR merge metrics
No merged PRs in 30d

Description

Hi !
The `addLink` function creates nodes if they do not exist. The data parameter of this function attaches ... data to the link. But what about created nodes ? They are created without data. Why not having created a function addLink with 3 data: one for the link, one for the "from" node and the last for the "to" node. I think you create Node with data before or after adding links but this is error prone in the case we forget some nodes.

Thx !

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the addLink API and trace how missing "from" and "to" nodes are created. Compare the existing link data parameter with the behavior of these created nodes. Done means deciding whether separate data for both created nodes should be supported and documenting or implementing the agreed API behavior with suitable coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.