anvaka / anvaka/VivaGraphJS

Constant layout does not handle node updates

Open
#166 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3.9k
Forks
418
PR merge metrics
No merged PRs in 30d

Description

When node is updated with constant layout, it is removed. Check line 67 of src/Layout/constant.js.
I suggest to turn it into

``` javascript
if (change.changeType === 'add' || change.changeType === 'update')
```

Same goes for line 73.
When changed like that, I can successfully update my nodes.

Please comment and fix.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by inspecting src/Layout/constant.js at lines 67 and 73, then reproduce an update to a node using the constant layout. Verify that updated nodes are retained and that the behavior works at both locations.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
computer-graphics
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.