antvis / antvis/G2Plot

Error = [Violation] Added non-passive event listener to a scroll-blocking

Open
#1,319 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
2.7k
Forks
591
PR merge metrics
No merged PRs in 30d

Description

Error on lib using Chrome = [Violation] Added non-passive event listener to a scroll-blocking event. Consider marking event handler as 'passive' to make the page more responsive.

Suggestion ([link](https://stackoverflow.com/questions/50983289/angular-4-added-non-passive-event-listener-to-a-scroll-blocking-mousewheel-e)):

By marking a touch or wheel listener as passive, the developer is promising the handler won't call preventDefault() to disable scrolling. This frees the browser up to respond to scrolling immediately without waiting for JavaScript, thus ensuring a reliably smooth scrolling experience for the user.

Where does occurs? All charts!

Screen Shot 2020-07-21 at 20 51 03

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the Chrome warning across the charts and tracing where the scroll-blocking event listeners are registered. Check whether the affected handlers need preventDefault; done means the warning is resolved without breaking chart scrolling or other interactions.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
data-visualization
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.