antonioru / antonioru/beautiful-react-diagrams

Getting Bug when removing node

Ouverte
#157 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
JavaScript
Étoiles
2.7k
Forks
171
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

**Describe the bug**
when i delete node getting undefined issue and its blocked the application

**To Reproduce**
Steps to reproduce the behavior:
1. Go to application
2. Click on remove node action
3. Inside console throwing error message
4. See error attachment.

**Expected behavior**
Should not block the page

**Screenshots**
added screenshots

**Desktop (please complete the following information):**
- OS: [iOS]
- Browser [e.g. chrome]
- Version [latest]

**Additional context**
The problem is to check index should be more than or equal to 0 not -1
Screenshot 2021-07-18 at 6 53 22 PM

1- node_modules/beautiful-react-diagrams/esm/hooks/useSchema/schemaReducer.js

case ON_NODE_REMOVE: { // remove all node's links
let nextLinks = state.links || [];
if (state.nodes) {
const index = findIndex(state.nodes, ['id', action.payload.nodeId]);
// rendering blocked when getting index === -1
**if (index >= 0) {**
const inputPorts = getNodePortsId(state.nodes[index], 'inputs');
const outputPorts = getNodePortsId(state.nodes[index], 'outputs');
nextLinks = nextLinks.filter(
(link) => !inputPorts.includes(link.input) && !outputPorts.includes(link.output),
);
state.nodes.splice(index, 1);
**}**
}

2- node_modules/beautiful-react-diagrams/esm/Diagram/Link/getEntityCoordinates.js

**if (portRefs && entity?.entity?.id && portRefs[entity.entity.id]) {**
var portEl = portRefs[entity.entity.id];

var _bbox = portEl.getBoundingClientRect();

return getRelativePoint([_bbox.x + _bbox.width / 2, _bbox.y + _bbox.height / 2], [canvas.x, canvas.y]);
}

3- node_modules/beautiful-react-diagrams/esm/Diagram/Link/Link.js

var pathOptions = {
**type: input?.type === 'port' || output?.type === 'port' ? 'bezier' : 'curve',**
**inputAlignment: input?.entity?.alignment || null,**
**outputAlignment: output?.entity?.alignment || null**
};

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.