antonioribeiro / antonioribeiro/tracker

getUri() --> uri()

Open
#265 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
2.9k
Forks
594
PR merge metrics
No merged PRs in 30d

Description

Using 5.4 here I had to change `getUri()` to `uri()` in `pragmarx/tracker/src/Data/RepositoryManager.php` to avoid an error. I assume it's triggered by the `log_routes = true` setting. On another note, tracker didn't work with a separate database (but that's perhaps my fault, and I didn't investigate further). Sorry for being not more precise.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in pragmarx/tracker/src/Data/RepositoryManager.php and inspect the getUri() call in the context of Laravel 5.4. Check whether the log_routes = true setting triggers the failure, and compare it with the reported uri() usage. Done means route logging no longer raises the reported error under Laravel 5.4.

Written by the indexing model from the issue text.

Assessment

Tech stack
laravel, php
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.