antonioribeiro / antonioribeiro/support
Not compatible with Laravel 10 Mailer
- Dominant language
- PHP
- Stars
- 58
- Forks
- 58
- PR merge metrics
- No merged PRs in 30d
Description
In [/laravel/framework/src/Illuminate/Mail/Mailer.php ](https://github.com/laravel/framework/blob/10.x/src/Illuminate/Mail/Mailer.php#L396) it uses the value() function with two arguments.
This corresponds with [laravel/framework/src/Illuminate/Collections/helpers.php](https://github.com/laravel/framework/blob/10.x/src/Illuminate/Collections/helpers.php#L186) where it accepts two arguments.
In helpers.php in this package (which gets loaded first and overrides the Laravel version) it only accepts one argument.
There is a [pull request](https://github.com/antonioribeiro/support/pull/32) to bring helpers.php up to date, but it has failed your tests as it's not compatible with php <=7.1. That shouldn't matter because Laravel is also not compatible with these versions of PHP.
Can the tests be updated and the pull request merged?
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by comparing src/Illuminate/Mail/Mailer.php in Laravel 10 with this package's helpers.php, then inspect pull request #32 and run the existing test suite. Done means the package's value() helper accepts the Laravel 10 call, the tests reflect the supported PHP versions, and the suite passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- laravel, php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- Half a day
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 30/100