antlr / antlr/antlr4

takari-lifecycle-plugin in main pom has no version explicitly set

Open
#3,902 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
19k
Forks
3.5k
PR merge metrics
No merged PRs in 30d

Description

- [x] I have reproduced my issue using the latest version of ANTLR
- [ ] I have asked at [stackoverflow](http://stackoverflow.com/questions/tagged/antlr4)
- [ ] Responses from the above seem to indicate that my issue could be an ANTLR bug
- [x] I have done a search of the existing issues to make sure I'm not sending in a duplicate

Please include the following information:
- target information (Java, C++ ...)
Java

- smallest possible grammar and code that reproduces the behavior
NA

- description of the expected behavior and actual behavior
I expect a fresh checkout and build to produce no warnings.
The actual behavior was production of several warnings:
```
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.antlr:antlr4-maven-plugin:maven-plugin:4.11.2-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for io.takari.maven.plugins:takari-lifecycle-plugin is missing. @ line 143, column 15
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
```
There are many other warnings, but those are already addressed in issue #3102

Pointers to suspicious code regions are also very welcome.
The antlr4-maven-plugin pom makes use of the takari-lifecycle-plugin, but doesn't explicitly set a version number. According to `mvn help:effective-pom` the version used on my dev machine build is 2.0.7. The maven repo says there is a version 2.0.9 available since 9/7/22:
https://mvnrepository.com/artifact/io.takari.maven.plugins/takari-lifecycle-plugin

Contributor guide

Open the contributing guide

Research direction

Find the antlr4-maven-plugin POM and locate the io.takari.maven.plugins:takari-lifecycle-plugin entry mentioned in the warning. Inspect the effective POM to confirm the inherited version, set the plugin version explicitly, then run a fresh Maven build and verify that this warning is gone.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.