antify / antify/ui

AntModal: Add max-height to modal

Open
#126 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
TypeScript
Stars
1
Forks
0
Avg merge
1d 15h
Merged PRs (30d)
3

Description

If a modal is taller than the screen, currently the top and bottom of the modal just get cut off.
Adding a max-height property fixes this issue which makes the Modal body scrollable with the header and footer being fixed.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the AntModal implementation and reproduce the case where the modal is taller than the screen. Add the requested max-height behavior so the body scrolls while the header and footer remain visible, then verify the result with an oversized modal.

Written by the indexing model from the issue text.

Assessment

Tech stack
tailwindcss, typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.