anthropics / anthropics/skills

possible XSS in skill-creator's templates.

Ouverte
#1,075 0 commentaires 3 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Python
Étoiles
176k
Forks
20.8k
Merge moyen
7 h 21 min
PR mergées (30 j)
5

Description

I've used a security extension for Gemini CLI on the skill-creator, and the extension reported vulnerabilities on scripts that embeds a JSON on a '' tags without escaping '<' and '>'.
I know this is probably a minor issue, but i'm open one just to let you know.

## Vulnerability: Cross-Site Scripting (XSS) │
Line Content: return template.replace("/*__EMBEDDED_DATA__*/", f"const EMBEDDED_DATA = {data_json};") Description: The `generate_review.py` script embeds a JSON string into a `<script>` tag inside the HTML template without escaping `<` and `>`. If the JSON contains a string with `alert(1)`, it can break out of the script tag and execute arbitrary Javascript in the user's browser when they view the review page. │

Recommendation: Escape the JSON string before embedding it into the HTML document. Specifically, `data_json = json.dumps(embedded).replace("<", "\\u003c").replace(">", "\\u003e").replace("&", "\\u0026")` should be used.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.