anthropics / anthropics/claude-code-action

claude-code-review workflow template generates insufficient permissions; action silently swallows write failure

Open
#1,121 1 comment 5 reactions 0 assignees View on GitHub
area:permissions bug p2
Dominant language
TypeScript
Stars
8.9k
Forks
2.1k
Avg merge
3d 9h
Merged PRs (30d)
10

Description

## Description

Two related bugs that compound each other, resulting in the code review action running successfully but silently posting no output anywhere.

## Bug 1: Generated workflow template has wrong permissions

The workflow template generated by the `/install-github-app` command sets `pull-requests: read`:

```yaml
permissions:
contents: read
pull-requests: read
issues: read
id-token: write
```

Posting review comments requires `pull-requests: write`. The template should include write permission since that is the entire purpose of the code review workflow.

## Bug 2: Action silently swallows the permission error

When the action attempts to post a review comment and receives a 403 from the GitHub API due to insufficient permissions, it exits 0. The job reports success with no indication that the review was never written anywhere.

## Expected behaviour

- The generated template should include `pull-requests: write`
- The action should fail the step (non-zero exit) when it receives a permission error trying to write a review, so the misconfiguration is surfaced immediately

## Impact

Without either fix, there is no feedback loop: the template is wrong, the action doesn't complain, the job shows green, and reviews silently go nowhere.

Contributor guide

Open the contributing guide

Research direction

Start at the /install-github-app command and locate the generated workflow template, then trace the code that posts review comments and handles GitHub API errors. Done means the template grants pull-requests: write and a permission-related write failure produces a non-zero action result instead of a successful run with no review output.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, typescript
Domain
ci-cd, devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.